Loki/Elastic: Assert queryfix value to always be string #81349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
grafana-pr-automation
bot
added
the
levitate breaking change
grafana-pr-automation
bot
requested review from
a team and
jackw
and removed request for
a team
svennergr
force-pushed
the
svennergr/fix-query-fix-types
branch
from
a6d2af4
to
2bb16b9
Compare
svennergr
changed the title
svennergr
added
type/bug
backport v10.3.x
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
svennergr
force-pushed
the
svennergr/fix-query-fix-types
branch
from
2bb16b9
to
9ec101d
Compare
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
Fix `value` can be `string` or `number` (cherry picked from commit ca5c297)
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
Fix `value` can be `string` or `number`
svennergr
added a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
The
valueof a QueryFixAction can actually benumberin some cases. With the current types we always assume it is astring. That leads to some errors when e.g. number values are being filtered.