Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loki: Fix label not being added to all subexpressions #81360

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Loki: Fix label not being added to all subexpressions #81360

merged 1 commit into from
Jan 26, 2024

Conversation

svennergr
Copy link
Contributor

What is this feature?

parsed and structured metadata labels were not properly added to all subexpressions.

Special notes for your reviewer:

  1. Start Grafana and Loki devenv
  2. Do 2 queries in explore:
  3. A: sum(rate({place="moon"} [$__auto])) / sum(rate({place="moon"} [$__auto]))
  4. B: {place="moon"}
  5. Use the log details of B to add label filters.
  6. Without this PR they wouldn't be added to all sub expressions.

@svennergr svennergr requested a review from a team as a code owner January 26, 2024 12:47
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.4.x milestone Jan 26, 2024
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

ivanahuckova
ivanahuckova approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⭐ for the test!

@svennergr svennergr enabled auto-merge (squash) January 26, 2024 13:01
@svennergr svennergr merged commit 9c728de into main Jan 26, 2024
26 checks passed
@svennergr svennergr deleted the svennergr/logs-filter-regression branch January 26, 2024 13:03
grafana-delivery-bot bot pushed a commit that referenced this pull request Jan 26, 2024
@svennergr @grafana-delivery-bot
Loki: Fix label not being added to all subexpressions (#81360)
1419816 
(cherry picked from commit 9c728de)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Jan 26, 2024
Merged
svennergr added a commit that referenced this pull request Jan 26, 2024
@grafana-delivery-bot @svennergr
[v10.3.x] Loki: Fix label not being added to all subexpressions (#81363)
537d7b4 
Loki: Fix label not being added to all subexpressions (#81360)

(cherry picked from commit 9c728de)

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
@svennergr @Ukochka
Loki: Fix label not being added to all subexpressions (#81360)
d99c2a1
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
@BrewTestBot BrewTestBot mentioned this pull request Mar 6, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanahuckova ivanahuckova ivanahuckova approved these changes

Assignees
No one assigned
Labels
add to changelog area/frontend backport v10.3.x Mark PR for automatic backport to v10.3.x datasource/Loki type/bug
Projects
None yet
Milestone
10.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@svennergr @ivanahuckova @aangelisc