[v10.2.x] Field: Fix perf regression in getUniqueFieldName() #81417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
Co-authored-by: nmarrs <nathanielmarrs@gmail.com> (cherry picked from commit 0530021)
grafana-delivery-bot
bot
requested review from
codeincarnate and
adela-almasan
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/frontend
backport
grafana-delivery-bot
bot
requested review from
joshhunt,
L-M-K-B,
leventebalogh,
a team,
jackw and
leeoniya
and removed request for
a team and
leventebalogh
leeoniya
approved these changes
Jan 26, 2024
nmarrs
reviewed
Jan 26, 2024
| @@ -1,4 +1,5 @@ | |||
| import { DefaultTimeZone, TimeRange, toUtc, SupplementaryQueryType } from '@grafana/data'; | |||
| import { TimeRange, toUtc, SupplementaryQueryType } from '@grafana/data'; | |||
| import { defaultTimeZone } from '@grafana/schema'; | |||
|
|
|||
There was a problem hiding this comment.
what's up with all of these import changes? 🤔
There was a problem hiding this comment.
there is a failing test, so i'm trying to cherry-pick a possibly related cleanup to try to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0530021 from #81323
Addresses https://github.com/grafana/support-escalations/issues/9134
this fixes a large perf regression in
getFieldDisplayName()introduced in #75511@ryantxu should we backport this?
NOTE: easiest to review each commit separately. the first one is the fix, the second one is an additional optimization for huge-field-count frames.