New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Add pagination and improved search for notification policies #81535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniaAguilarPeiron
added
area/alerting
Grafana Alerting
area/frontend
add to changelog
no-backport
Skip backport of PR
labels
Jan 30, 2024
soniaAguilarPeiron
requested review from
gillesdemey and
konrad147
and removed request for
a team
January 30, 2024 08:01
soniaAguilarPeiron
changed the title
Alerting: add show more pagination and search feedback to policies view
Alerting: Add pagination and search feedback to policies view
Jan 30, 2024
soniaAguilarPeiron
changed the title
Alerting: Add pagination and search feedback to policies view
Alerting: Add pagination and search feedback to the policies view
Jan 30, 2024
gillesdemey
reviewed
Jan 31, 2024
public/app/features/alerting/unified/components/notification-policies/Policy.tsx
Show resolved
Hide resolved
public/app/features/alerting/unified/components/notification-policies/Policy.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Konrad Lalik <konradlalik@gmail.com>
gillesdemey
force-pushed
the
alerting/policy-view-improvements
branch
from
February 15, 2024 17:54
0fbeb34
to
ee1a250
Compare
I don't think it makes sense to allow showing fewer policies – why did the user click it in the first place if they weren't interested?
gillesdemey
changed the title
Alerting: Add pagination and search feedback to the policies view
Alerting: Add pagination and improved search for notification policies
Feb 15, 2024
gillesdemey
force-pushed
the
alerting/policy-view-improvements
branch
from
February 15, 2024 19:21
7fddeeb
to
89ea71b
Compare
/deploy-to-hg |
|
This comment was marked as off-topic.
This comment was marked as off-topic.
/deploy-to-hg |
konrad147
reviewed
Feb 16, 2024
public/app/features/alerting/unified/components/notification-policies/Policy.tsx
Show resolved
Hide resolved
public/app/features/alerting/unified/components/notification-policies/Policy.tsx
Outdated
Show resolved
Hide resolved
public/app/features/alerting/unified/components/notification-policies/Policy.tsx
Show resolved
Hide resolved
Resolved @konrad147 's questions during 🍐-programming session |
gillesdemey
approved these changes
Feb 16, 2024
konrad147
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
add to what's new
area/alerting
Grafana Alerting
area/frontend
no-backport
Skip backport of PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds several improvements to the policies view.
So far, if we have a big number of policies, the UI becomes very slow in this page. The interaction in this page becomes pretty irresponsive.
With this PR we introduce several things that fix this problem and also improve the user experience when searching.
{numberofpoliciesHidden} additional policies
button to expand the list of the branch that exceeds this X numberWhy do we need this feature?
UI should support big number of policies.
Who is this feature for?
All users.
Which issue(s) does this PR fix?:
Fixes #73038
Special notes for your reviewer:
pagination.mp4
About the filter results:
filter-results.mp4
Please check that: