Tooltips: Hide dimension configuration when tooltip mode is hidden #81627
Conversation
codeincarnate
requested review from
ashharrison90,
JoaoSilvaGrafana and
sunker
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
| @@ -52,6 +52,7 @@ export function addTooltipOptions<T extends OptionsWithTooltip>( | |||
| integer: true, | |||
| placeholder: '300', | |||
| }, | |||
| showIf: (options: T) => options.tooltip?.mode !== TooltipDisplayMode.None, | |||
There was a problem hiding this comment.
| showIf: (options: T) => options.tooltip?.mode !== TooltipDisplayMode.None, | |
| showIf: (options: T) => config.featureToggles.newVizTooltips && options.tooltip?.mode !== TooltipDisplayMode.None, |
There was a problem hiding this comment.
hm just tried to add this locally and ran into issue where it seems we are not able to pull the config object from grafana runtime anymore in the grafana-ui package... made this thread in frontend channel to ask about this 😬
There was a problem hiding this comment.
ugh, yeah, I forgot about imports 😬 it's not possible as far as I know, I've also asked a while ago and we ended up moving Timeseries out of grafana-ui and do the imports.. So maybe we should leave it as is, we're going to remove the feature flag in the near future anyway 😞
There was a problem hiding this comment.
Following up from thread it appears there is no way to access the feature toggles from the run time config
The only way that this would be feasible is through passing this info as a prop to the component - which could be a viable solution for the time being
There was a problem hiding this comment.
We may need to talk about this as currently these options are being exposed regardless of the tooltip usage. This PR doesn't impact that so I may go ahead and merge anyhow, and we can address this being displayed in another PR
|
Hey, looks good! I just realized that these options are just for the new tooltips, so I suggested to add that to the condition. Also Heatmap needs to be updated and it should be good to go 😁 |
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
| @@ -52,6 +52,7 @@ export function addTooltipOptions<T extends OptionsWithTooltip>( | |||
| integer: true, | |||
| placeholder: '300', | |||
| }, | |||
| showIf: (options: T) => options.tooltip?.mode !== TooltipDisplayMode.None, | |||
There was a problem hiding this comment.
hm just tried to add this locally and ran into issue where it seems we are not able to pull the config object from grafana runtime anymore in the grafana-ui package... made this thread in frontend channel to ask about this 😬
|
Going to merge this for now as these fields are already showing regardless. Going to make sure to do a follow-up for this one so we can hopefully disable these fields showing when using old tooltips. |
codeincarnate
changed the title
What is this feature?
This PR hides the width and height settings for the tooltip when the mode is set to Hidden as these options won't apply in that case.
This can be seen in action below:
Screen.Recording.2024-01-31.at.5.30.45.PM.mov
Why do we need this feature?
This removes potential confusion when configuring tooltips as in this case the width and height settings will not have any effect.
Who is this feature for?
Users that want to disable tooltips.
Special notes for your reviewer:
Please check that: