Elasticsearch: Implement CheckHealth method in the backend #81671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
grafana-pr-automation
bot
added
area/backend
datasource/Elasticsearch
pr/external
|
Hey @mikelv92 ! Thanks for your contribution. We'll reviewing as soon as we have some bandwidth. Stay tunned! |
|
Thank you in advance for the review. I have already signed the CLA but I think the bot isn't updating the workflow... |
Thanks @mikelv92. Just to be sure, did you add the email used for the commit to your Github account? That's needed for the CLA to be marked as signed. |
|
Unfortunately, I used the wrong email in the first commit... It's fixed now :) |
mikelv92
force-pushed
the
es-checkhealth
branch
from
2ef899e
to
00521cc
Compare
This reverts commit 676265f.
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
* Elasticsearch: Implement CheckHealth method * improve logger output * remove frontend healthcheck * Revert "remove frontend healthcheck" This reverts commit 676265f. * adapt test --------- Co-authored-by: Sven Grossmann <svennergr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
ElasticSearch does not have a CheckHealth method in the backend code implemented. This PR adds a CheckHealth so that the
/api/datasources/uid/:uid/healthendpoint will return the health information.Why do we need this feature?
Currently the /health endpoint is not working.
Who is this feature for?
Users that want to check the health of the datasource when using Elasticsearch
Which issue(s) does this PR fix?:
Fixes #63727
Special notes for your reviewer:
make devenv sources=elasticgdev-elasticsearchdatasource, openhttp://localhost:3000/api/datasources/uid/gdev-elasticsearch/health
Please check that: