Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Licensing: Redact license when overriden by env variable #81726

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Licensing: Redact license when overriden by env variable #81726

merged 1 commit into from
Feb 1, 2024

Conversation

leandro-deveikis
Copy link
Contributor

@leandro-deveikis leandro-deveikis commented Feb 1, 2024 •
edited
Loading

What is this feature?
Adds Grafana License env variable as one of the redacted variables in the logs
Tested locally and logs are shown as expected.

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@leandro-deveikis leandro-deveikis requested a review from a team as a code owner February 1, 2024 16:39
@leandro-deveikis leandro-deveikis requested review from zserge, idafurjes and yangkb09 and removed request for a team February 1, 2024 16:39
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.4.x milestone Feb 1, 2024
@leandro-deveikis leandro-deveikis merged commit 7ab833d into main Feb 1, 2024
24 checks passed
@leandro-deveikis leandro-deveikis deleted the ldeveikis/avoid_print_license branch February 1, 2024 17:37
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
@leandro-deveikis @Ukochka
Licensing: Redact license when overriden by env variable (#81726)
0dea72c
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
@BrewTestBot BrewTestBot mentioned this pull request Mar 6, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papagian papagian papagian approved these changes

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@idafurjes idafurjes Awaiting requested review from idafurjes idafurjes was automatically assigned from grafana/backend-platform

@yangkb09 yangkb09 Awaiting requested review from yangkb09 yangkb09 was automatically assigned from grafana/backend-platform

Assignees
No one assigned
Labels
add to changelog area/backend no-backport Skip backport of PR
Projects
None yet
Milestone
10.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leandro-deveikis @papagian @aangelisc