CloudWatch: Remove references to pkg/infra/metrics #81744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
changed the title
iwysiu
requested review from
idastambuk,
kevinwcyu,
papagian,
suntala and
idafurjes
and removed request for
a team
iwysiu
commented
Feb 2, 2024
| GetMetricDataLabel = "get_metric_data" | ||
| ) | ||
|
|
||
| var QueriesTotalCounter = promauto.NewCounterVec( |
There was a problem hiding this comment.
In the example this is a global, but is that ok with future multitenant plans?
There was a problem hiding this comment.
Checked with the multi-tenancy group, and it's fine. We want metrics to be across all tenants, and we're not storing sensitive data
idastambuk
approved these changes
Feb 5, 2024
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
CloudWatch: remove references to pkg/infra/metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Replaces the counters that we had in
pkg/infra/metricswith the method external plugins use. I'm curious if we're actually using these for anything, considering that theMAwsCloudWatchGetMetricStatisticswasn't ever being incremented.Why do we need this feature?
We need to decouple the CloudWatch plugin from core datasources
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #80898
Special notes for your reviewer:
Please check that: