Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Never disable add new data source for core plugins #81774

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Plugins: Never disable add new data source for core plugins #81774

merged 5 commits into from
Feb 5, 2024

Conversation

oshirohugo
Copy link
Contributor

@oshirohugo oshirohugo commented Feb 2, 2024 •
edited
Loading

What is this feature?

Never disable "Add new data source" for core plugin in cloud

Why do we need this feature?

This feature is needed to fix the issue where the button "Add new data source" is disabled for cloud plugins

Who is this feature for?

Plugins users

Which issue(s) does this PR fix?:

Fixes #81766

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@oshirohugo oshirohugo self-assigned this Feb 2, 2024
@oshirohugo oshirohugo requested a review from a team as a code owner February 2, 2024 10:04
@oshirohugo oshirohugo requested review from Ukochka and removed request for a team February 2, 2024 10:04
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.4.x milestone Feb 2, 2024
andresmgot
andresmgot reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that isFullyInstalled is used in another place (usePluginConfig). Wouldn't it be more correct to say that core plugins are fully installed?

@oshirohugo oshirohugo changed the title Plugins: never disable add new data source for core plugins Plugins: Never disable add new data source for core plugins Feb 2, 2024
andresmgot
andresmgot reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test? :)

andresmgot
andresmgot approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, LGTM!

@oshirohugo oshirohugo merged commit ed62aef into main Feb 5, 2024
13 checks passed
@oshirohugo oshirohugo deleted the fix-core-plugin-disable-in-cloud branch February 5, 2024 08:32
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
@oshirohugo @Ukochka
Plugins: Never disable add new data source for core plugins (#81774)
1ce121d
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
@BrewTestBot BrewTestBot mentioned this pull request Mar 6, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

@Ukochka Ukochka Awaiting requested review from Ukochka Ukochka is a code owner automatically assigned from grafana/plugins-platform-frontend

Assignees

@oshirohugo oshirohugo

Labels
add to changelog area/frontend area/plugins area/plugins-catalog no-backport Skip backport of PR type/bug
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
10.4.0
Development

Successfully merging this pull request may close these issues.

bug: managedPluginInstall toggle disables add datasource for core plugins
3 participants
@oshirohugo @andresmgot @aangelisc