Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browse Dashboards: Imported dashboards now display immediately in the dashboard list #81819

Merged
merged 5 commits into from Feb 6, 2024
Merged

Browse Dashboards: Imported dashboards now display immediately in the dashboard list #81819

merged 5 commits into from Feb 6, 2024
+92 −33

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

  • creates an importDashboard method in rtk query
    • this correctly causes the parent folder to refetch it's children on fulfilment of the import
  • updates the import action to call the importDashboard method in rtk query

Why do we need this feature?

  • so the cache is correctly invalidated when importing dashboards

Who is this feature for?

  • everyone!

Which issue(s) does this PR fix?:

Fixes https://github.com/grafana/support-escalations/issues/9238

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 ashharrison90 added this to the 10.4.x milestone Feb 2, 2024
@ashharrison90 ashharrison90 self-assigned this Feb 2, 2024
@ashharrison90 ashharrison90 requested review from grafanabot and a team as code owners February 2, 2024 17:11
@ashharrison90 ashharrison90 requested review from joshhunt, eledobleefe, oscarkilhed and ivanortegaalba and removed request for a team February 2, 2024 17:11
eledobleefe
eledobleefe approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@eledobleefe eledobleefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on local and works as expected. Good job 👌

@ashharrison90 ashharrison90 merged commit e2c2704 into main Feb 6, 2024
14 checks passed
@ashharrison90 ashharrison90 deleted the ash/import-rtk-query branch February 6, 2024 10:46
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
@ashharrison90 @Ukochka
Browse Dashboards: Imported dashboards now display immediately in the…
03e0f98 
… dashboard list (#81819)

* create importDashboard method in rtk query

* fix unit tests

* Revert "fix unit tests"

This reverts commit 72cd81c.

* fix unit test
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
@BrewTestBot BrewTestBot mentioned this pull request Mar 6, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eledobleefe eledobleefe eledobleefe approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@oscarkilhed oscarkilhed Awaiting requested review from oscarkilhed oscarkilhed is a code owner automatically assigned from grafana/dashboards-squad

@ivanortegaalba ivanortegaalba Awaiting requested review from ivanortegaalba ivanortegaalba is a code owner automatically assigned from grafana/dashboards-squad

Assignees

@ashharrison90 ashharrison90

Labels
add to changelog area/frontend no-backport Skip backport of PR type/bug
Projects
Grafana Frontend Platform
Archived in project
Milestone
10.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashharrison90 @eledobleefe @aangelisc