Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings: Change 'h' to 'mod+h' to open help modal #82253

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

tskarhed
Copy link
Contributor

@tskarhed tskarhed commented Feb 9, 2024

What is this feature?
Updates the help modal to open on mod+h instead of just h.

Some other cleanup updates:

  • Use CSS object for styles
  • Use theme.shape.radius.default for displaying keys instead of borderRadius(3)

Why do we need this feature?

WCAG recommendation is that a modifier is needed, as having just a single character may interfere with assistive technologies.

Who is this feature for?
Mainly keyboard users

Fixes #74841

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@tskarhed tskarhed requested review from grafanabot and a team as code owners February 9, 2024 13:12
@tskarhed tskarhed requested review from joshhunt and JoaoSilvaGrafana and removed request for a team February 9, 2024 13:12
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.4.x milestone Feb 9, 2024
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 👏 But if you wanted more work to replace the css with components also feel free 😅

public/app/core/components/help/HelpModal.tsx Show resolved Hide resolved
@tskarhed tskarhed merged commit d91803c into main Feb 12, 2024
24 checks passed
@tskarhed tskarhed deleted the a11y-fix-help branch February 12, 2024 10:54
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
@frebib
Copy link

frebib commented Jun 18, 2024

This seems to be hijacking Ctrl+H in Firefox on Linux with seemingly no way to prevent it? Can a different key combination be used, or a way provided to turn these off?

@tskarhed
Copy link
Contributor Author

@frebib This has been fixed in #85449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Accessibility issue] The h key alone opens the keyboard shortcut modal which can cause some users issues
5 participants