Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibraryPanels: Fix issue with repeated library panels #82255

Merged
merged 1 commit into from Feb 9, 2024
Merged

LibraryPanels: Fix issue with repeated library panels #82255

merged 1 commit into from Feb 9, 2024

Conversation

kaydelaney
Copy link
Contributor

@kaydelaney kaydelaney commented Feb 9, 2024 •
edited by oscarkilhed

Fixes an issue where a library panel being repeated by a template variable would briefly use the All value for the first repeat instance.

@kaydelaney
LibraryPanels: Fix issue with repeated library panels
c121888 
Fixes an issue where a library panel being repeated by a
template variable would briefly use the All value for the first
repeat instance
@kaydelaney kaydelaney self-assigned this Feb 9, 2024
@kaydelaney kaydelaney requested a review from a team as a code owner February 9, 2024 13:29
@kaydelaney kaydelaney requested review from axelavargas and dprokop and removed request for a team February 9, 2024 13:29
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.4.x milestone Feb 9, 2024
oscarkilhed
oscarkilhed approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@oscarkilhed oscarkilhed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾 It works!

@kaydelaney kaydelaney modified the milestone: 10.4.x Feb 9, 2024
@kaydelaney kaydelaney added the backport v10.3.x Mark PR for automatic backport to v10.3.x label Feb 9, 2024
@kaydelaney kaydelaney merged commit 984d2da into main Feb 9, 2024
29 checks passed
@kaydelaney kaydelaney deleted the fix-lib-panel-repeats branch February 9, 2024 13:48
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

Hello @kaydelaney!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

Hello @kaydelaney!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@kaydelaney kaydelaney added backport v10.3.x Mark PR for automatic backport to v10.3.x and removed backport v10.3.x Mark PR for automatic backport to v10.3.x labels Feb 9, 2024
grafana-delivery-bot bot pushed a commit that referenced this pull request Feb 9, 2024
@kaydelaney @grafana-delivery-bot
LibraryPanels: Fix issue with repeated library panels (#82255)
8d4734e 
Fixes an issue where a library panel being repeated by a
template variable would briefly use the All value for the first
repeat instance

(cherry picked from commit 984d2da)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Feb 9, 2024
Merged
kaydelaney added a commit that referenced this pull request Feb 9, 2024
@grafana-delivery-bot @kaydelaney
[v10.3.x] LibraryPanels: Fix issue with repeated library panels (#82259)
6d54337 
LibraryPanels: Fix issue with repeated library panels (#82255)

Fixes an issue where a library panel being repeated by a
template variable would briefly use the All value for the first
repeat instance

(cherry picked from commit 984d2da)

Co-authored-by: kay delaney <45561153+kaydelaney@users.noreply.github.com>
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
@kaydelaney @Ukochka
LibraryPanels: Fix issue with repeated library panels (#82255)
830daf0 
Fixes an issue where a library panel being repeated by a
template variable would briefly use the All value for the first
repeat instance
@aangelisc aangelisc removed this from the 10.4.x milestone Mar 6, 2024
@aangelisc aangelisc added this to the 10.4.0 milestone Mar 6, 2024
@BrewTestBot BrewTestBot mentioned this pull request Mar 6, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarkilhed oscarkilhed oscarkilhed approved these changes

@axelavargas axelavargas Awaiting requested review from axelavargas axelavargas is a code owner automatically assigned from grafana/dashboards-squad

@dprokop dprokop Awaiting requested review from dprokop dprokop is a code owner automatically assigned from grafana/dashboards-squad

Assignees

@kaydelaney kaydelaney

Labels
add to changelog area/dashboard/templating area/dashboard area/frontend/library-panels area/frontend backport v10.3.x Mark PR for automatic backport to v10.3.x type/bug
Projects
Dashboards
Status: 🚀 Done
Milestone
10.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaydelaney @oscarkilhed @aangelisc