Alerting: Return provenance of notification templates #82274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
requested review from
a team,
rwwiv,
JacobsonMT,
yuri-tceretian and
grobinson-grafana
and removed request for
a team
Noticed that this endpoint, unlike other provisioning endpoints, does not return the provenance (while setting it works) This should add it to the response
julienduchesne
force-pushed
the
julienduchesne/notification-templates-provenance
branch
from
40e6523
to
c5ecffa
Compare
yuri-tceretian
deleted the
julienduchesne/notification-templates-provenance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this endpoint, unlike other provisioning endpoints, does not return the provenance in the GET operations (while setting it does work).
This PR should add it to the response by building the
NotificationTemplateobjects in the service, and setting the provenance there, rather than building the object in the API, where the provenance is unavailable