Elasticsearch: Fix resource calls for paths that include :

[ivanahuckova]

This PR follows up on #79746 and removes redundant logic that was using url.Parse to parse req.Path. Consequently, it also fixes the issue #79745 where url.Parse throws error when parsing path with :. Moreover it adds tests and does a small refactor to make testing of these (and future) changes easier.

To test, do a sanity check that resource calls work:

See field options:

Adhoc filters working:

Test data source working:

Fixes: #82327

[svennergr]

Hm, are we sure we never need or want to support query parameters in resources calls? Because I think some APIs in ES use GET query parameters, so I think we should also add this to createElasticsearchURL. WDYT?

[ivanahuckova]

Resource path should not have any RawQuery based on following check req.Path != "" && !strings.HasSuffix(req.Path, "/_mapping") && req.Path != "_msearch" && req.Path != "_mapping". So it is not needed as there are currently no queries supported. Maybe I can add a comment explaining it - so when someone allows additional path/resource calls, they are aware of needing to implement raw query.

I also noticed that I haven't add test for why we are doing it - so I will also add test for path with : to ensure that it is covered.

But to summarise we can't use url.Parse(req.Path) anymore as it throws error for path that includes : , so I am worried, that if we wanted to go 1 step ahead and implement raw queries (even if it is not needed), we might introduce some issue related to splitting on ?. Or do you have any other ideas.

[ivanahuckova]

bbacb56

[svennergr]

LGTM