Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Send alerts to APIv2 when using the Alertmanager contact point #82373

Merged
merged 1 commit into from Feb 13, 2024

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Feb 13, 2024

What is this feature?

This pull request updates Grafana to send alerts to Alertmanager apiv2 when using the Alertmanager contact point, as apiv1 is now deprecated. It grafana/alerting to 92f64f0 to fix grafana/alerting#159.

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grobinson-grafana grobinson-grafana self-assigned this Feb 13, 2024
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner February 13, 2024 13:22
@grobinson-grafana grobinson-grafana added this to the 10.4.x milestone Feb 13, 2024
@grobinson-grafana grobinson-grafana added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Feb 13, 2024
Copy link
Member

@JohnnyQQQQ JohnnyQQQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grobinson-grafana grobinson-grafana enabled auto-merge (squash) February 13, 2024 13:31
@grobinson-grafana grobinson-grafana merged commit 556d531 into main Feb 13, 2024
25 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/update-alerting branch February 13, 2024 13:37
@grobinson-grafana grobinson-grafana added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Feb 16, 2024
@grobinson-grafana grobinson-grafana changed the title Alerting: Update grafana/alerting to 92f64f0 Alerting: Use Alertmanager APIv2 when sending alerts via an Alertmanager contact point Feb 16, 2024
@grobinson-grafana grobinson-grafana changed the title Alerting: Use Alertmanager APIv2 when sending alerts via an Alertmanager contact point Alerting: Send alerts to APIv2 when using the Alertmanager contact point Feb 16, 2024
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants