Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs Panel: Add CSV to download options #82480

Merged
merged 7 commits into from Feb 15, 2024

Conversation

gtk-grafana
Copy link
Contributor

@gtk-grafana gtk-grafana commented Feb 14, 2024

What is this feature?
Adding CSV option to logs download.
image

Why do we need this feature?
We got this feedback quite a bit from the logs table feedback form while it was in public preview.
While there is a CSV download in the query inspector the labels aren't extracted so it's not really helpful, also it's not anywhere near the other download options in the UI so I get that users are confused.

Who is this feature for?
Users of logs in explore.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.4.x milestone Feb 14, 2024
@gtk-grafana gtk-grafana marked this pull request as ready for review February 15, 2024 13:09
@gtk-grafana gtk-grafana requested a review from a team as a code owner February 15, 2024 13:09
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good! I think we should process all logRows though, not just the first one - mainly with logs viz. With table only, I wouldn't mind it, as we are selecting there rows, but there we are not showing selected logs, but the first logs.

public/app/features/explore/Logs/LogsMetaRow.tsx Outdated Show resolved Hide resolved
@ivanahuckova
Copy link
Member

ivanahuckova commented Feb 15, 2024

@gtk-grafana the tests seems to be failing. Otherwise lgtm.

@gtk-grafana gtk-grafana enabled auto-merge (squash) February 15, 2024 15:07
@gtk-grafana gtk-grafana self-assigned this Feb 15, 2024
@gtk-grafana gtk-grafana merged commit d071f41 into main Feb 15, 2024
14 checks passed
@gtk-grafana gtk-grafana deleted the gtk-grafana/logs/poc/csv-download branch February 15, 2024 15:42
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants