New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tempo: Upgrade @grafana/lezer-traceql patch version to use trace metrics syntax #82532
Conversation
So it looks like after the updates to include metrics syntax, we exposed an existing issue that was incorrectly building the tree for Anyway, updated the PR to reflect a more specific error message and to also update the autocomplete for the If you wouldn't mind taking another look @adrapereira / @fabrizio-grafana that would be great! Note I plan to add more specific highlighting / possibly autocomplete for the new syntax in a subsequent PR. |
Ohh I should note that I'm not 100% sure why adding in the metrics syntax caused a change in how the tree is build. My guess is some kind of precedence but not certain. For context: I believe it was the lines with the |
Yeah probably, IIRC it happened also to me, but it shouldn't be a problem. In fact, I think we should also rethink tests in the |
@@ -1028,6 +1028,12 @@ | |||
"count": 5 | |||
} | |||
], | |||
"/packages/grafana-ui/src/components/Splitter/Splitter.tsx": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are changes to .betterer.results.json
intended? I don't understand them 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like these were left over from other PR's that I merged in from main. Not related to this PR but a side effect of making a commit. Honestly not sure why.
What is this feature?
Upgrades @grafana/lezer-traceql patch version to use trace metrics syntax.
Why do we need this feature?
Add syntax support for trace metrics queries, introduced in this PR.
Who is this feature for?
Tempo users.
Special notes for your reviewer: