Cloudwatch: Add linting to restrict imports from core #82538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
changed the title
idastambuk
requested review from
gabor,
kevinwcyu,
njvrzm,
diegommm,
undef1nd and
yangkb09
and removed request for
a team
idastambuk
commented
Feb 15, 2024
| @@ -122,7 +122,7 @@ func NewInstanceSettings(httpClientProvider *httpclient.Provider) datasource.Ins | |||
| } | |||
| } | |||
|
|
|||
| // cloudWatchExecutor executes CloudWatch requests. | |||
| // cloudWatchExecutor executes CloudWatch requests | |||
There was a problem hiding this comment.
to trigger BE checks
gabor
reviewed
Feb 15, 2024
.golangci.toml
Outdated
| @@ -67,6 +67,7 @@ files = [ | |||
| "**/pkg/tsdb/parca/**/*", | |||
| "**/pkg/tsdb/tempo/*", | |||
| "**/pkg/tsdb/tempo/**/*", | |||
| "**/pkg/tsdb/cloudwatch/**/*", | |||
There was a problem hiding this comment.
i don't know how exactly this thing works, but other datasources have 2 lines each... cloudwatch only 1. is this intentional?
kevinwcyu
approved these changes
Feb 15, 2024
Co-authored-by: Kevin Yu <kevinwcyu@users.noreply.github.com>
Co-authored-by: Kevin Yu <kevinwcyu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Final step of removing FE + BE dependencies on core grafana. Enables linting for CW to prevent core grafana imports
Which issue(s) does this PR fix?:
Fixes #78845
Special notes for your reviewer:
Please check that: