Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parca: Apply template variables for labelSelector in query #82910

Conversation

lzakharov
Copy link
Contributor

What is this feature?

Applies variables for the labelSelector in a Parca query.

Why do we need this feature?

Template variables can be used when querying from Parca.

Who is this feature for?

Parca users.

Special notes for your reviewer:

This PR is based on the #64324.

@lzakharov lzakharov requested a review from a team as a code owner February 16, 2024 15:26
@CLAassistant
Copy link

CLAassistant commented Feb 16, 2024

CLA assistant check
All committers have signed the CLA.

@grafana-pr-automation grafana-pr-automation bot added area/frontend pr/external This PR is from external contributor labels Feb 16, 2024
@lzakharov lzakharov force-pushed the feature-parca-datasource-template-variables branch from 510a5d4 to ba83afd Compare February 16, 2024 15:36
@joey-grafana joey-grafana added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Feb 20, 2024
@joey-grafana joey-grafana added this to the 10.5.x milestone Feb 20, 2024
@joey-grafana joey-grafana added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Feb 20, 2024
Copy link
Contributor

@joey-grafana joey-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only thing needed was to remove some unused imports in case you were wondering why the CI step failed previously 👍 Thank you very much for your contribution!

@joey-grafana joey-grafana added the datasource/Parca Parca datasource label Feb 20, 2024
@joey-grafana joey-grafana merged commit 8138ca3 into grafana:main Feb 20, 2024
16 checks passed
@aangelisc aangelisc modified the milestones: 10.5.x, 11.0.x Feb 20, 2024
@lzakharov
Copy link
Contributor Author

Thanks for the quick review and fixes!

@lzakharov lzakharov deleted the feature-parca-datasource-template-variables branch February 22, 2024 14:19
@lzakharov lzakharov restored the feature-parca-datasource-template-variables branch February 22, 2024 14:19
@lzakharov lzakharov deleted the feature-parca-datasource-template-variables branch February 22, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend datasource/Parca Parca datasource no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants