Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Fix panic in provisioning filter contacts by unknown name #83070

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Alerting: Fix panic in provisioning filter contacts by unknown name #83070

merged 1 commit into from
Feb 19, 2024

Conversation

JacobsonMT
Copy link
Member

What is this feature?

Prevents a panic for index out of range when querying api/v1/provisioning/contact-points with a name query parameter that filters for a contact point name that doesn't exist.

Why do we need this feature?

Prevent panic.

Who is this feature for?

Users of alerting provisioning API / alerting Terraform provider.

@JacobsonMT JacobsonMT added this to the 10.4.x milestone Feb 19, 2024
@JacobsonMT JacobsonMT requested review from a team, rwwiv, yuri-tceretian and grobinson-grafana and removed request for a team February 19, 2024 15:16
@JacobsonMT JacobsonMT enabled auto-merge (squash) February 19, 2024 15:26
@JacobsonMT JacobsonMT merged commit 87ab98e into main Feb 19, 2024
25 checks passed
@JacobsonMT JacobsonMT deleted the jacobsonmt/fix-provisioning-contact-point-read-error branch February 19, 2024 15:30
@aangelisc aangelisc modified the milestones: 10.4.x, 11.0.x Feb 20, 2024
@julienduchesne julienduchesne mentioned this pull request Jun 4, 2024
Closed
@mengjie-ms
Copy link

Hi @JacobsonMT , @fabrizio-grafana , could you please backport the fix to v10, we have seen many "index out of range" error in v10.4.x. Thank you very much!

@brahmnes
Copy link

brahmnes commented Jul 3, 2024

Hi @JacobsonMT, @fabrizio-grafana , this looks like a simple fix and we would appreciate if it can be backported to Grafana 10.
Thank you!

CC @aangelisc

@ryan-grafana ryan-grafana added the product-approved Pull requests that are approved by product/managers and are allowed to be backported label Jul 15, 2024
@ryan-grafana
Copy link

approved to backport from product

@JacobsonMT JacobsonMT added backport v10.4.x and removed no-backport Skip backport of PR labels Jul 15, 2024
grafana-delivery-bot bot pushed a commit that referenced this pull request Jul 15, 2024
@JacobsonMT @grafana-delivery-bot
Alerting: Fix panic in provisioning filter contacts by unknown name (#…
39077e3 
…83070)

(cherry picked from commit 87ab98e)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request Jul 15, 2024
Merged
JacobsonMT added a commit that referenced this pull request Jul 15, 2024
@grafana-delivery-bot @JacobsonMT
[v10.4.x] Alerting: Fix panic in provisioning filter contacts by unkn…
9c9d47e 
…own name (#90440)

Alerting: Fix panic in provisioning filter contacts by unknown name (#83070)

(cherry picked from commit 87ab98e)

Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grobinson-grafana grobinson-grafana grobinson-grafana approved these changes

@rwwiv rwwiv Awaiting requested review from rwwiv

@yuri-tceretian yuri-tceretian Awaiting requested review from yuri-tceretian

Assignees
No one assigned
Labels
add to changelog area/alerting Grafana Alerting area/backend area/provisioning backport v10.4.x product-approved Pull requests that are approved by product/managers and are allowed to be backported type/bug
Projects
Alerting
Status: Done
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JacobsonMT @mengjie-ms @brahmnes @ryan-grafana @grobinson-grafana @aangelisc @fabrizio-grafana