Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFrame: Improve typing of arrayToDataFrame helper and fix null/undefined handling #83104

Merged
merged 2 commits into from
Feb 21, 2024
Merged

DataFrame: Improve typing of arrayToDataFrame helper and fix null/undefined handling #83104

merged 2 commits into from
Feb 21, 2024

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented Feb 20, 2024 •
edited
Loading

Tried to figure out how arrayDataFrame worked and found some issues I tried to fix here:

  • Add comments
  • Add types to make sure it's clear it's either array of simple values or array of objects (rows)
  • Fix handling of null/undefined values which was broken as far as I could tell

@aocenas aocenas requested review from grafanabot and a team as code owners February 20, 2024 13:40
@aocenas aocenas requested review from Clarity-89, JoaoSilvaGrafana and leventebalogh and removed request for a team February 20, 2024 13:40
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.4.x milestone Feb 20, 2024
@aocenas aocenas requested review from ryantxu and kylebrandt and removed request for Clarity-89, JoaoSilvaGrafana and leventebalogh February 20, 2024 13:40
@aocenas aocenas requested a review from a team February 20, 2024 13:41
@aocenas aocenas changed the title DataFrame: Fix and improve the arrayDataFrame helpers DataFrame: Fix and improve the arrayDataFrame helper Feb 20, 2024
@aocenas aocenas changed the title DataFrame: Fix and improve the arrayDataFrame helper DataFrame: Fix and improve the arrayToDataFrame helper Feb 20, 2024
ryantxu
ryantxu approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks

@aangelisc aangelisc modified the milestones: 10.4.x, 11.0.x Feb 20, 2024
@aocenas aocenas merged commit d48bf34 into main Feb 21, 2024
34 checks passed
@aocenas aocenas deleted the aocenas/dataframe/array-data-frame-fixes branch February 21, 2024 09:14
@aocenas aocenas changed the title DataFrame: Fix and improve the arrayToDataFrame helper DataFrame: Improve typing of arrayToDataFrame helper and fix null/undefined handling Feb 21, 2024
yuri-tceretian pushed a commit that referenced this pull request Feb 26, 2024
@aocenas @yuri-tceretian
DataFrame: Improve typing of arrayToDataFrame helper and fix null/und…
ae790ca 
…efined handling (#83104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantxu ryantxu ryantxu approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@kylebrandt kylebrandt Awaiting requested review from kylebrandt

@leeoniya leeoniya Awaiting requested review from leeoniya

Assignees
No one assigned
Labels
add to changelog area/dataframe area/frontend
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aocenas @ryantxu @aangelisc @fabrizio-grafana