-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Use time_intervals instead of the deprecated mute_time_intervals in a… #83147
Conversation
…lert manager config
/deploy-to-hg |
|
|
good catch! I will update the pr with this use case. |
…ce when deleting mute timing
…ce when saving a new or existing alert rule
ba2c8ee
to
1c4c1b8
Compare
I tested it and LGTM! I'll let @gillesdemey and @konrad147 do the code review and approval. |
public/app/features/alerting/unified/components/mute-timings/MuteTimingForm.tsx
Outdated
Show resolved
Hide resolved
public/app/features/alerting/unified/components/mute-timings/MuteTimingForm.tsx
Outdated
Show resolved
Hide resolved
public/app/features/alerting/unified/components/mute-timings/MuteTimingForm.tsx
Outdated
Show resolved
Hide resolved
public/app/features/alerting/unified/components/mute-timings/MuteTimingsTable.tsx
Outdated
Show resolved
Hide resolved
public/app/features/alerting/unified/hooks/useMuteTimingOptions.ts
Outdated
Show resolved
Hide resolved
88ea4fb
to
36876f2
Compare
36876f2
to
a0c72c2
Compare
a0c72c2
to
7386fcd
Compare
What is this feature?
This PR updates the way we use time intervals , after the the deprecation of mute_time_intervals from the alert manager config.
In this PR:
Grafana Alertmanager
Use
mute_time_intervals
andtime_intervals
when showing the UI, and save only onmute_time_intervals
External Alertmanager
mute_time_intervals
andtime_intervals
when showing the UI.time_intervals
when creating new time intervals in the UI.mute_time_interval
save it back as amute_time_interval
, and if it came from atime_interval
save it back as atime_interval
Fixes part of this issue
Why do we need this feature?
#83168
Who is this feature for?
All users.
Special notes for your reviewer:
Please check that: