[v10.4.x] DataQuery: Track panel plugin id not type #83164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
(cherry picked from commit 64e0a42)
grafana-delivery-bot
bot
requested review from
dprokop and
mdvictor
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/backend
area/frontend
backport
grafana-delivery-bot
bot
requested review from
ashharrison90,
eledobleefe,
sunker,
wbrowne,
marefr,
andresmgot and
torkelo
and removed request for
a team
torkelo
approved these changes
Feb 21, 2024
torkelo
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 64e0a42 from #83091
Tweaks #81164
Almost everywhere we refer to specific plugins by id not type (plugin.json they have an id), everywhere in the code base it's by id we refer to plugins (except in dashoard json where it's a type property name).
I would like to change this panel tracking property / header to use the name we have aligned on. Plugin type I think we should avoid unless we talking about different forms of plugins (Panel, Data source, App etc)