Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.4.x] Alerting: Fix saving evaluation group. #83234

Merged
merged 1 commit into from Feb 22, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 2a1873f from #83188


What is this feature?

This PR fix evaluation group modal.
The bug was introduced by this PR was applied (we were comparing the namespace name without taking in account that in grafana managed groups it has been encoded.)

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

fix saving evaluation group

(cherry picked from commit 2a1873f)
@soniaAguilarPeiron soniaAguilarPeiron merged commit e229eef into v10.4.x Feb 22, 2024
22 checks passed
@soniaAguilarPeiron soniaAguilarPeiron deleted the backport-83188-to-v10.4.x branch February 22, 2024 14:34
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
@zserge zserge modified the milestones: 10.4.0, 10.4.x Mar 12, 2024
@mdvictor mdvictor modified the milestones: 10.4.x, 10.4.1 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants