DataTrails: Sticky controls

[torkelo]

I think this simple take on it works quite well and can be refined later.

Cool things to consider in the future

• An option to include main graph in sticky bit (but should be an optional option in the options dropdown we removed)
• Possibly an option to disable sticky (not sure we need it)

agent_request_duration_seconds_bucket---Metrics---Explore---Grafana.mp4

[adrapereira]

Stickying the main graph would be nice, I'll add it in a following PR

[darrenjaneczek]

Why conditional? Do primary and canvas not look good here depending on isDark?

[torkelo]

@darrenjaneczek data trails is breaking out normal background rules. normally we would not do this. we would use theme.colors.background.primary

but for data trails I am testing a different pattern, using canvas for dark theme and primary for light theme

[darrenjaneczek]

Maybe in the future, something like theme.colors.background.trailsCanvas?

[catherineymgui]

Thanks Torkel!

1. Noticed this interaction when someone adds a label filter - the whole page resets and I wasn't sure what happened.
   https://github.com/grafana/grafana/assets/5264102/3aedab70-61c0-4f94-9feb-7fe60a8e768c

Is there a way we can keep the same "sticky" filter on interaction? Or have the filters expand on interaction? The original idea

2. On the metric select page - could we also sticky the search and prefix filter? However since this is 3 lines of sticky filtering (and there are other usability challenges w/ the prefix filter) - we will be moving prefix filter out.

[torkelo]

Is there a way we can keep the same "sticky" filter on interaction? Or have the filters expand on interaction? The original idea

@catherineymgui sadly when you add a new filter we have to query and rebuild a lot of the breakdown views, and the browser loses the scroll position during this process. We could remember it and try to scroll back but this requires some tricky code.

On the metric select page - could we also sticky the search and prefix filter? However since this is 3 lines of sticky filtering (and there are other usability challenges w/ the prefix filter) - we will be moving prefix filter out.

Yes, I think we could move the search up into the filters row. could be cramped if there are lot of filters but usually not the case on the select metric view. But this requires a bigger change (as the current select metric view is also used in the related metrics tab). So leaving that for the follow PRs