Canvas: Add ability to rotate elements #83295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarrs
added
add to changelog
area/panel/canvas
|
Few comments:
|
nmarrs
changed the title
nmarrs
requested review from
codeincarnate and
baldm0mma
and removed request for
a team
…tated elements (not perfect but "good enough" for time being)
nmarrs
commented
Mar 21, 2024
| @@ -408,6 +424,10 @@ export class Scene { | |||
| draggable: allowChanges && !this.editModeEnabled.getValue(), | |||
| resizable: allowChanges, | |||
|
|
|||
| // Setup rotatable | |||
| rotatable: allowChanges, | |||
| throttleRotate: 5, | |||
There was a problem hiding this comment.
This is in effect our version of angle "snapping" making it easier to get to 45, 90, 180 etc values without explicitly setting in the placement editor
| const originalDirTB = dirTB; | ||
|
|
||
| dirLR = Math.sign(originalDirLR * Math.cos(rotationInRadians) - originalDirTB * Math.sin(rotationInRadians)); | ||
| dirTB = Math.sign(originalDirLR * Math.sin(rotationInRadians) + originalDirTB * Math.cos(rotationInRadians)); |
There was a problem hiding this comment.
and you thought you were done with geometry in school? 🎒
codeincarnate
approved these changes
Mar 22, 2024
baldm0mma
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Nice! Works as expected! I will say the snapping to other elements, especially if there are A LOT of elements feels a little jarring. But that's maybe not something we can easily change, since it is the expected behavior.
Screen.Recording.2024-03-22.at.1.40.52.PM.mov
drew08t
reviewed
Mar 22, 2024
Comment on lines
+396
to
+401
| enableCustomables = () => { | ||
| this.moveable!.props = { | ||
| dimensionViewable: true, | ||
| constraintViewable: true, | ||
| settingsViewable: true, | ||
| }; |
drew08t
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More relatively low hanging fruit similar to #80407
Add ability to rotate canvas elements via the rotatable functionality that already exists inside the moveable library. This was previously implemented temporarily for the cancad hackathon project
Screen.Recording.2024-03-21.at.1.51.35.PM.mov
TODO
Known issues / next steps