Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudWatch: Refactor "getDimensionValuesForWildcards" #83335

Merged
merged 1 commit into from
Feb 26, 2024
Merged

CloudWatch: Refactor "getDimensionValuesForWildcards" #83335

merged 1 commit into from
Feb 26, 2024

Conversation

iwysiu
Copy link
Contributor

@iwysiu iwysiu commented Feb 23, 2024 •
edited
Loading

Split off from #83278 . This pr refactors getDimensionValuesForWildcards to get the listMetricsPageLimit from the caller (which already has the instance) instead of having to fetch it again.
part of #82194

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@iwysiu iwysiu added add to changelog no-backport Skip backport of PR labels Feb 23, 2024
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Feb 23, 2024
This was referenced Feb 23, 2024
Merged
Closed
@iwysiu iwysiu marked this pull request as ready for review February 23, 2024 19:41
@iwysiu iwysiu requested a review from a team as a code owner February 23, 2024 19:41
@iwysiu iwysiu requested review from kevinwcyu and njvrzm and removed request for a team February 23, 2024 19:41
@iwysiu iwysiu merged commit bdeff84 into main Feb 26, 2024
28 checks passed
@iwysiu iwysiu deleted the iwysiu/82194d branch February 26, 2024 21:19
chalapat pushed a commit to nokia/grafana that referenced this pull request Feb 27, 2024
@iwysiu @chalapat
CloudWatch: Refactor "getDimensionValuesForWildcards" (grafana#83335)
1f3ffad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinwcyu kevinwcyu kevinwcyu approved these changes

@njvrzm njvrzm Awaiting requested review from njvrzm njvrzm is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
add to changelog area/backend datasource/CloudWatch no-backport Skip backport of PR
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iwysiu @kevinwcyu @fabrizio-grafana