Dashboards: Fixes issue where panels would not refresh if time range updated while in panel view mode #83418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updated while in panel view mode
kaydelaney
added
type/bug
area/dashboard
area/frontend
add to changelog
backport v10.3.x
kaydelaney
requested review from
axelavargas and
mdvictor
and removed request for
a team
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
axelavargas
reviewed
Feb 26, 2024
There was a problem hiding this comment.
The code looks good to me 🙌🏾 , great work @kaydelaney
Btw, It seems this bug was always present 🤔, can we add some unit tests for this?
I found this test suite, it looks like a good place to add this test case: https://github.com/grafana/grafana/blob/main/public/app/features/dashboard/state/DashboardModel.refresh.test.ts
|
I have a follow-up PR that fixes the tests. :) It changes a few other related things too, so I'm leaving it for that |
axelavargas
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where panels would not refresh upon exiting panel view if the time range was updated while viewing the panel.