Alerting: Fix editing Grafana folder via alert rule editor #83771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillesdemey
added
type/bug
area/alerting
gillesdemey
requested review from
konrad147 and
soniaAguilarPeiron
and removed request for
a team
gillesdemey
deleted the
alerting/fix-editing-grafana-group-from-rule-editor
branch
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
(cherry picked from commit fc10600)
gillesdemey
added a commit
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Prior to this PR editing a Grafana alert rule and updating the group details from there would result in a "404 not found / permission denied" error from the backend because we weren't treating it as a Grafana folder (when
folderUidisundefinedit assumes we are trying to update a Mimir group).