Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Panel: Fix condition for showing footer options #83801

Merged
merged 2 commits into from Mar 4, 2024

Conversation

codeincarnate
Copy link
Collaborator

What is this feature?

This PR fixes an issue in which the Fields selection for the table footer will show even when the table footer isn't enabled.

Why do we need this feature?

Makes table panel configuration more consistent and less confusing.

Who is this feature for?

Users configuring the table panel.

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Mar 1, 2024
@codeincarnate codeincarnate self-assigned this Mar 1, 2024
@codeincarnate codeincarnate marked this pull request as ready for review March 1, 2024 22:40
@codeincarnate codeincarnate requested a review from a team as a code owner March 1, 2024 22:40
@codeincarnate codeincarnate requested review from Develer and nmarrs and removed request for a team March 1, 2024 22:40
@codeincarnate codeincarnate merged commit 13f037d into main Mar 4, 2024
14 checks passed
@codeincarnate codeincarnate deleted the codeincarnate/table-footer-config branch March 4, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants