Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.2.x] Cloudwatch: Fix errors while loading queries/datasource on Safari #83842

Merged
merged 1 commit into from Mar 4, 2024
Merged

[v10.2.x] Cloudwatch: Fix errors while loading queries/datasource on Safari #83842

merged 1 commit into from Mar 4, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 377262c from #79417

Which issue(s) does this PR fix?:

Fixes #79347

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@kevinwcyu @grafana-delivery-bot
Cloudwatch: Fix errors while loading queries/datasource on Safari (#7…
37fe0d0 
…9417)

* pass super.query to query runners

* fix types in tests

* clearer name for query function

* fix test

(cherry picked from commit 377262c)
@grafana-delivery-bot grafana-delivery-bot bot requested a review from a team as a code owner March 4, 2024 15:27
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Mar 4, 2024
@grafana-delivery-bot grafana-delivery-bot bot requested review from sarahzinger and kevinwcyu and removed request for a team March 4, 2024 15:27
@grafana-delivery-bot grafana-delivery-bot bot added add to changelog area/frontend backport A backport PR datasource/CloudWatch product-approved Pull requests that are approved by product/managers and are allowed to be backported labels Mar 4, 2024
@tolzhabayev
Copy link
Contributor

@kevinwcyu one of our customers is hitting this issue on their production on-prem stack, may I backport it to 10.2 for their build?

@kevinwcyu
Copy link
Contributor

@tolzhabayev, yes, it should be fine to backport.

@tolzhabayev tolzhabayev merged commit fd6028a into v10.2.x Mar 4, 2024
22 checks passed
@tolzhabayev tolzhabayev deleted the backport-79417-to-v10.2.x branch March 4, 2024 16:15
@aangelisc aangelisc modified the milestones: 10.2.x, 10.2.5 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolzhabayev tolzhabayev tolzhabayev approved these changes

@sarahzinger sarahzinger Awaiting requested review from sarahzinger sarahzinger is a code owner automatically assigned from grafana/aws-datasources

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
add to changelog area/frontend backport A backport PR datasource/CloudWatch product-approved Pull requests that are approved by product/managers and are allowed to be backported
Projects
None yet
Milestone
10.2.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tolzhabayev @kevinwcyu @aangelisc