Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas: Add datalink support to rectangle and ellipse elements #83870

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

nmarrs
Copy link
Contributor

@nmarrs nmarrs commented Mar 4, 2024

Add datalink support to rectangle and ellipse elements

Before

before.mov

After

after.mov

Add support of datalinks to more elements-1709595415129.json

Fixes #83346

Opened up this new GitHub issue to explore supporting datalinks for the remainder of canvas elements (i.e. icon, server, maybe button (as another mode potentially of just click and go to data link instead of API call)) etc.

@nmarrs nmarrs added add to changelog area/panel/canvas Issues related to canvas panel no-backport Skip backport of PR labels Mar 4, 2024
@nmarrs nmarrs self-assigned this Mar 4, 2024
@nmarrs nmarrs requested a review from a team as a code owner March 4, 2024 23:40
@nmarrs nmarrs requested review from Develer and drew08t and removed request for a team March 4, 2024 23:40
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Mar 4, 2024
Copy link
Contributor

@baldm0mma baldm0mma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected locally for me! Nice!

Copy link
Collaborator

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nmarrs nmarrs merged commit 5c27d28 into main Mar 5, 2024
19 checks passed
@nmarrs nmarrs deleted the canvas-add-datalink-support-to-rectangle-and-ellipse branch March 5, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canvas: Consider supporting datalink functionality for any data driven element
5 participants