[v10.4.x] GenAI: Update the component only when the response is fully generated #83895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
…t respond (#83879) * Update the component only when the response is fully generated * Fix quick feedback action doesn't respond * Fix history not displaying after the second click * Fix the history that moves when regenerating --------- Co-authored-by: Adela Almasan <88068998+adela-almasan@users.noreply.github.com> (cherry picked from commit 112c0e7)
grafana-delivery-bot
bot
requested review from
oscarkilhed and
Sergej-Vlasov
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/frontend
backport
ivanortegaalba
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 112c0e7 from #83879
Fixes #79611, #76848
Problem
The previous approach triggered a set state for every stream response. This was causing the component to enter into many re-renders, where React was stopping them and missing part of the message.
Solution
Do not set the state on every stream result, and accumulate the response to only commit the set state when it is fully completed. This changes the experience, but we want to try with this approach, to ensure the experience is performant enough.