Chore: Remove deprecated exploreId from QueryEditorProps #83971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elfo404
requested review from
joshhunt,
eledobleefe,
mckn and
a team
and removed request for
a team
Elfo404
added
add to changelog
breaking change
grafana-dataRemovalsExploreQueryFieldProps.exploreId/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts exploreId?: string;QueryEditorProps.exploreId /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts exploreId?: string; |
grafana-pr-automation
bot
added
the
levitate breaking change
mckn
approved these changes
Mar 7, 2024
|
@mckn it should not be needed anymore, it was used only to check if a plugin was rendered in explore or not, but there are now better ways to do that. |
Then the question is, what are the better ways of doing it? |
|
|
ifrost
approved these changes
Mar 11, 2024
xlson
added a commit
that referenced
this pull request
Mar 11, 2024
* main: (1014 commits) Dashboards: Update scenes lib to 3.10 (#84075) Playlist: run on Scenes (#83551) E2C: Add cloud migration is_target server config option (#83419) Update dependency marked to v12.0.1 Chore: Remove deprecated ExploreQueryFieldProps (#83972) Chore: Remove deprecated exploreId from QueryEditorProps (#83971) Documentation: Updated yaml for influxdb data sources (#84119) Schemas: Reduce duplicated jenny code (#84061) Update dependency immer to v10.0.4 CloudMigration: wires the service (#84081) Chore: Remove InputControl usage from explore (#83742) Chore: Remove Form components from TransformationsEditor (#83743) DatePickerWithInput: Set zIndex for popover correctly (#84154) Scenes/Repeats: Show reduced panel menu for repeat panels (#84085) Update dependency centrifuge to v5.0.2 Update dependency autoprefixer to v10.4.18 Accessibility: Improve landmark markup (#83576) Update dependency @types/node to v20.11.25 Scenes: Row controls (#83607) Dashboard scenes: Remove panel menu options that are dashboard editing activities when not in edit mode. (#84156) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the deprecated (in
10.3)exploreIdproperty fromQueryEditorProps.Fixes #78747
Release notice breaking change
Since #38942
exploreIdis no longer supplied to query editors in Explore. The property was deprecated in10.3.0and is now removed. If your query editor needs to know from which app is being rendered, you can check theappprop inQueryEditorProps.