-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Remove deprecated ExploreQueryFieldProps #83972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana-dataRemovalsExploreQueryFieldProps/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts ExploreQueryFieldProps ExploreQueryFieldProps.DSType /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts DSType extends DataSourceApi ExploreQueryFieldProps.TQuery /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts TQuery extends DataQuery = DataQuery ExploreQueryFieldProps.TOptions /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts TOptions extends DataSourceJsonData = DataSourceJsonData ExploreQueryFieldProps.TVQuery /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts TVQuery extends DataQuery = TQuery ExploreQueryFieldProps.datasource /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts datasource: DSType; ExploreQueryFieldProps.query /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts query: TVQuery; ExploreQueryFieldProps.onRunQuery /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts onRunQuery: () => void; ExploreQueryFieldProps.onChange /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts onChange: (value: TVQuery) => void; ExploreQueryFieldProps.onBlur /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts onBlur?: () => void; ExploreQueryFieldProps.onAddQuery /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts onAddQuery?: (query: TQuery) => void; ExploreQueryFieldProps.data /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts data?: PanelData; ExploreQueryFieldProps.range /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts range?: TimeRange; ExploreQueryFieldProps.exploreId /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts exploreId?: string; ExploreQueryFieldProps.history /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts history?: Array>; ExploreQueryFieldProps.queries /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts queries?: DataQuery[]; ExploreQueryFieldProps.app /home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts app?: CoreApp; |
mckn
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I can only find really old plugins using this or it being referenced in clones of Grafana. Should be Ok to remove.
ifrost
approved these changes
Mar 11, 2024
xlson
added a commit
that referenced
this pull request
Mar 11, 2024
* main: (1014 commits) Dashboards: Update scenes lib to 3.10 (#84075) Playlist: run on Scenes (#83551) E2C: Add cloud migration is_target server config option (#83419) Update dependency marked to v12.0.1 Chore: Remove deprecated ExploreQueryFieldProps (#83972) Chore: Remove deprecated exploreId from QueryEditorProps (#83971) Documentation: Updated yaml for influxdb data sources (#84119) Schemas: Reduce duplicated jenny code (#84061) Update dependency immer to v10.0.4 CloudMigration: wires the service (#84081) Chore: Remove InputControl usage from explore (#83742) Chore: Remove Form components from TransformationsEditor (#83743) DatePickerWithInput: Set zIndex for popover correctly (#84154) Scenes/Repeats: Show reduced panel menu for repeat panels (#84085) Update dependency centrifuge to v5.0.2 Update dependency autoprefixer to v10.4.18 Accessibility: Improve landmark markup (#83576) Update dependency @types/node to v20.11.25 Scenes: Row controls (#83607) Dashboard scenes: Remove panel menu options that are dashboard editing activities when not in edit mode. (#84156) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/frontend
breaking change
Relevant for changelog generation
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
no-backport
Skip backport of PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #38942 (grafana
8.2.0
) theExploreQueryFieldProps
type was deprecated. This PR removes it.Release notice breaking change
Since #38942 (Grafana
8.2.0
) theExploreQueryFieldProps
type was deprecated and is now removed.