Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove deprecated ExploreQueryFieldProps #83972

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

Elfo404
Copy link
Member

@Elfo404 Elfo404 commented Mar 6, 2024

Since #38942 (grafana 8.2.0) the ExploreQueryFieldProps type was deprecated. This PR removes it.

Release notice breaking change

Since #38942 (Grafana 8.2.0) the ExploreQueryFieldProps type was deprecated and is now removed.

@Elfo404 Elfo404 added add to changelog breaking change Relevant for changelog generation no-backport Skip backport of PR labels Mar 6, 2024
@Elfo404 Elfo404 requested a review from a team March 6, 2024 13:19
@Elfo404 Elfo404 requested review from a team as code owners March 6, 2024 13:19
@Elfo404 Elfo404 requested review from tskarhed, L-M-K-B and academo and removed request for a team March 6, 2024 13:19
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Mar 6, 2024
@grafana-pr-automation
Copy link

⚠️   Possible breaking changes (md version)   ⚠️

grafana-data

Removals

ExploreQueryFieldProps
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
ExploreQueryFieldProps

ExploreQueryFieldProps.DSType
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
DSType extends DataSourceApi

ExploreQueryFieldProps.TQuery
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
TQuery extends DataQuery = DataQuery

ExploreQueryFieldProps.TOptions
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
TOptions extends DataSourceJsonData = DataSourceJsonData

ExploreQueryFieldProps.TVQuery
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
TVQuery extends DataQuery = TQuery

ExploreQueryFieldProps.datasource
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
datasource: DSType;

ExploreQueryFieldProps.query
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
query: TVQuery;

ExploreQueryFieldProps.onRunQuery
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
onRunQuery: () => void;

ExploreQueryFieldProps.onChange
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
onChange: (value: TVQuery) => void;

ExploreQueryFieldProps.onBlur
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
onBlur?: () => void;

ExploreQueryFieldProps.onAddQuery
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
onAddQuery?: (query: TQuery) => void;

ExploreQueryFieldProps.data
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
data?: PanelData;

ExploreQueryFieldProps.range
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
range?: TimeRange;

ExploreQueryFieldProps.exploreId
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
exploreId?: string;

ExploreQueryFieldProps.history
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
history?: Array>;

ExploreQueryFieldProps.queries
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
queries?: DataQuery[];

ExploreQueryFieldProps.app
/home/runner/work/grafana/grafana/base/grafana-data/dist/index.d.ts
app?: CoreApp;


Read our guideline
Console output

@grafana-pr-automation grafana-pr-automation bot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Mar 6, 2024
@grafana-pr-automation grafana-pr-automation bot requested a review from a team March 6, 2024 13:24
Copy link
Contributor

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can only find really old plugins using this or it being referenced in clones of Grafana. Should be Ok to remove.

@Elfo404 Elfo404 merged commit c950b71 into main Mar 11, 2024
34 of 35 checks passed
@Elfo404 Elfo404 deleted the gio/chore/remove-explorequeryfieldsprops branch March 11, 2024 12:10
xlson added a commit that referenced this pull request Mar 11, 2024
* main: (1014 commits)
  Dashboards: Update scenes lib to 3.10 (#84075)
  Playlist: run on Scenes (#83551)
  E2C: Add cloud migration is_target server config option (#83419)
  Update dependency marked to v12.0.1
  Chore: Remove deprecated ExploreQueryFieldProps (#83972)
  Chore: Remove deprecated exploreId from QueryEditorProps (#83971)
  Documentation: Updated yaml for influxdb data sources (#84119)
  Schemas: Reduce duplicated jenny code (#84061)
  Update dependency immer to v10.0.4
  CloudMigration: wires the service (#84081)
  Chore: Remove InputControl usage from explore (#83742)
  Chore: Remove Form components from TransformationsEditor (#83743)
  DatePickerWithInput: Set zIndex for popover correctly (#84154)
  Scenes/Repeats: Show reduced panel menu for repeat panels (#84085)
  Update dependency centrifuge to v5.0.2
  Update dependency autoprefixer to v10.4.18
  Accessibility: Improve landmark markup (#83576)
  Update dependency @types/node to v20.11.25
  Scenes: Row controls (#83607)
  Dashboard scenes: Remove panel menu options that are dashboard editing activities when not in edit mode. (#84156)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend breaking change Relevant for changelog generation levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants