-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Updated yaml for influxdb data sources #84119
Conversation
Updated instructions for influx v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the specifics of this data source but I noticed in https://github.com/ldomesjo/grafana/commit/8c7639738d0440ab8889cae6a9f05e5a0a59e929 that this was originally changed from something similar to what you have proposed to what is currently in the file.
I'll tag the engineer that made that change to see if they can provide some information:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versions and data were mixed up. Thanks for noticing it and fixing it!
@jdbaldry It is good to go. Thanks for pinging! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thank you!
@itsmylife can you merge this pull request? I seem to be missing the required permissions to do so |
* main: (1014 commits) Dashboards: Update scenes lib to 3.10 (#84075) Playlist: run on Scenes (#83551) E2C: Add cloud migration is_target server config option (#83419) Update dependency marked to v12.0.1 Chore: Remove deprecated ExploreQueryFieldProps (#83972) Chore: Remove deprecated exploreId from QueryEditorProps (#83971) Documentation: Updated yaml for influxdb data sources (#84119) Schemas: Reduce duplicated jenny code (#84061) Update dependency immer to v10.0.4 CloudMigration: wires the service (#84081) Chore: Remove InputControl usage from explore (#83742) Chore: Remove Form components from TransformationsEditor (#83743) DatePickerWithInput: Set zIndex for popover correctly (#84154) Scenes/Repeats: Show reduced panel menu for repeat panels (#84085) Update dependency centrifuge to v5.0.2 Update dependency autoprefixer to v10.4.18 Accessibility: Improve landmark markup (#83576) Update dependency @types/node to v20.11.25 Scenes: Row controls (#83607) Dashboard scenes: Remove panel menu options that are dashboard editing activities when not in edit mode. (#84156) ...
What is this feature?
I believe the documentation for how to add a influxdb datasource was missing a few properties so I updated the documentation to reflect what is working for me
Why do we need this feature?
To help others which want to add an influx v2 datasource to Grafana
Who is this feature for?
Users that are looking for an example on how to add a influxdb v2 datasource to grafana