-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InfluxDB: Fix for wrong query generated with template variable and non regex operator on frontend mode #84175
Conversation
Signed-off-by: Syed Nihal <syed.nihal@nokia.com>
Signed-off-by: Syed Nihal <syed.nihal@nokia.com>
@wasim-nihal The PR looks good. But in the CI there are some errors. Could you please run |
sure. |
Signed-off-by: Syed Nihal <syed.nihal@nokia.com>
Done. Could you please re-trigger? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It appears to work as expected:
demo.fix.81517.mov
I made a few suggestions. Probably the most pressing one is fixing the > infuxdb
InfluxDB
spelling issues.
public/app/plugins/datasource/influxdb/influx_query_model.test.ts
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/influxdb/influx_query_model.test.ts
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/influxdb/influx_query_model.test.ts
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/influxdb/influx_query_model.test.ts
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/influxdb/influx_query_model.test.ts
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/influxdb/influx_query_model.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you please check @NWRichmond 's comments too? Then I think we are good to go. Thanks for this contribution!
Signed-off-by: Syed Nihal <syed.nihal@nokia.com>
@itsmylife , @NWRichmond , thanks for reviewing this change. I have addressed the comments in the latest commit. |
Seeing some linting issues again in CI. Will push the changes. |
Signed-off-by: Syed Nihal <syed.nihal@nokia.com>
Done |
I triggered the build and waiting for it to start. Thanks for the fixes. |
@wasim-nihal Thank you for the contribution once more! 🚀 |
What is this feature?
When using a single value regex variable with a non-regex operator (e.g.
=
), and you convert the query from builder to code editor, it leaves the regex wrapper around the variable in the expression, and wraps that in a single quote, which leads to a broken query expression. This PR is fixing it.Why do we need this feature?
Better query generation while switching between editors
Who is this feature for?
InfluxDB users building InfluxQL queries on grafana
Which issue(s) does this PR fix?:
Fixes #81517
Special notes for your reviewer:
Please check that: