Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.3.x] Postgres: Allow disabling SNI on SSL-enabled connections #84259

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

papagian
Copy link
Contributor

Backport 22d8258 from #83892


What is this feature?

Starting from version 1.10.7 lib/pq enables SNI.
However, this may be undesirable for some cases
Also, causes tls-mode verify-ca not to work correctly #65816

Why do we need this feature?

This introduces a new database configuration for disabling sslsni by setting it to 0.
By default is unset (fallbacks to the default lib/pq behaviour).

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #65816

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

* Postgres: Allow disabling SNI on SSL-enabled connections

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
(cherry picked from commit 22d8258)
@papagian papagian added this to the 10.3.x milestone Mar 12, 2024
@papagian papagian requested review from torkelo, a team and chri2547 as code owners March 12, 2024 11:16
@papagian papagian requested review from diegommm, mildwonkey and undef1nd and removed request for a team March 12, 2024 11:16
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs approved. Thanks for the contribution!

@papagian papagian merged commit cd81c5e into v10.3.x Mar 20, 2024
12 checks passed
@papagian papagian deleted the backport-83892-to-v10.3.x branch March 20, 2024 15:26
@yuri-tceretian yuri-tceretian modified the milestones: 10.3.x, 10.3.5 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants