Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n: Add Brazilian Portuguese #84461

Merged
merged 4 commits into from Mar 21, 2024
Merged

I18n: Add Brazilian Portuguese #84461

merged 4 commits into from Mar 21, 2024

Conversation

joshhunt
Copy link
Contributor

  • Adds Brazilian Portuguese as a supported language to Grafana.
  • Sorts the language picker in preferences by the label
  • Reformats the "How to add a new language" docs. They were correct before, but I thoughts they could do with a tweak for clarity.

Note - this should not be merged until we have translations for pt-br in Grafana, to avoid this option showing up in preferences but not doing anything.

@joshhunt joshhunt changed the title Add pt-br as supported language I18n: Add Brazilian Portuguese Mar 14, 2024
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Mar 14, 2024
@eledobleefe
Copy link
Contributor

According to your note, should this not be in the 'blocked' column while there are no translations for pt-br in Grafana? 🤔

@joshhunt joshhunt modified the milestone: 11.0.x Mar 14, 2024
@joshhunt joshhunt marked this pull request as ready for review March 21, 2024 11:37
@joshhunt joshhunt requested review from a team as code owners March 21, 2024 11:37
@joshhunt joshhunt requested review from Clarity-89, JoaoSilvaGrafana, moxious, tonypowa and eledobleefe and removed request for a team March 21, 2024 11:37
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legal 🇧🇷

@joshhunt joshhunt enabled auto-merge (squash) March 21, 2024 11:44
@joshhunt joshhunt merged commit b525de0 into main Mar 21, 2024
15 checks passed
@joshhunt joshhunt deleted the joshhunt/add-pt-br branch March 21, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants