Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: When virtualised is true the items get's wrong top position #84542

Closed
torkelo opened this issue Mar 15, 2024 · 2 comments
Closed

Select: When virtualised is true the items get's wrong top position #84542

torkelo opened this issue Mar 15, 2024 · 2 comments
Labels
area/grafana/ui Issues that belong to components in the @grafana/ui library internal for issues made by grafanistas type/bug

Comments

@torkelo
Copy link
Member

torkelo commented Mar 15, 2024 •
edited

  • Create a Select with a few options
  • Select an option 3 options down
  • Open the menu again, notice the empty space above and the top 2 options are not visible

Screenshot 2024-03-15 at 09 44 24

Forms-Select---Basic-Virtualized-List-Bug-.-Storybook.mp4

Looks like it's caused by initialScrollOffset here:
https://github.com/grafana/grafana/blob/main/packages/grafana-ui/src/components/Select/SelectMenu.tsx#L71

It is fixed If I remove that line, maybe bug in react-window?
@torkelo torkelo added the internal for issues made by grafanistas label Mar 15, 2024
@torkelo torkelo changed the title Select: When virtualised is true the items get's wrong top positoin Select: When virtualised is true the items get's wrong top position Mar 15, 2024
@torkelo torkelo added area/grafana/ui Issues that belong to components in the @grafana/ui library type/bug labels Mar 15, 2024
@torkelo torkelo mentioned this issue Mar 15, 2024
Merged
@eledobleefe
Copy link
Contributor

Hi @torkelo, correct me if I'm wrong, but didn't your PR fix this issue? Should we close it as done? 🤔

@torkelo
Copy link
Member Author

torkelo commented Mar 28, 2024

@eledobleefe yes, we can close this

@torkelo torkelo closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/grafana/ui Issues that belong to components in the @grafana/ui library internal for issues made by grafanistas type/bug
Projects
Grafana Frontend Platform
Status: 🚀 Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@torkelo @eledobleefe