Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestedFolders: Enable nested folders by default #84631

Merged
merged 5 commits into from
Mar 22, 2024
Merged

NestedFolders: Enable nested folders by default #84631

merged 5 commits into from
Mar 22, 2024

Conversation

zserge
Copy link
Contributor

@zserge zserge commented Mar 18, 2024 •
edited by joshhunt
Loading

馃帀, I suppose?

P.S. I expect to merge this around Wednesday (March, 20th)

Fixes #10339

@zserge zserge added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Mar 18, 2024
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Mar 18, 2024
@zserge zserge marked this pull request as ready for review March 18, 2024 10:02
@zserge zserge requested a review from a team as a code owner March 18, 2024 10:02
tolzhabayev
tolzhabayev approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@tolzhabayev tolzhabayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌

tolzhabayev
tolzhabayev reviewed Mar 18, 2024
View reviewed changes
pkg/services/featuremgmt/registry.go Outdated
@@ -274,6 +274,7 @@ var (
Description: "Enable folder nesting",
Stage: FeatureStagePublicPreview,
Copy link
Contributor

@tolzhabayev tolzhabayev Mar 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to change this to GA or else the checks fail

--- FAIL: TestFeatureToggleFiles (0.01s)
    --- FAIL: TestFeatureToggleFiles/check_registry_constraints (0.00s)
        toggles_gen_test.go:38: only FeatureStageGeneralAvailability or FeatureStageDeprecated features can be enabled by default.  See: nestedFolders

@zserge zserge requested a review from grafanabot as a code owner March 20, 2024 13:47
@zserge zserge force-pushed the zserge/enable-nested-folders branch 2 times, most recently from 69d564c to d98fc18 Compare March 20, 2024 15:31
@zserge zserge requested review from a team as code owners March 22, 2024 11:23
@zserge zserge requested review from tskarhed and JoaoSilvaGrafana and removed request for a team March 22, 2024 11:23
@zserge zserge force-pushed the zserge/enable-nested-folders branch from 72836f5 to f740e42 Compare March 22, 2024 12:54
@zserge zserge merged commit df2d057 into main Mar 22, 2024
15 checks passed
@zserge zserge deleted the zserge/enable-nested-folders branch March 22, 2024 13:13
@joshhunt joshhunt added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Mar 22, 2024
@joshhunt joshhunt changed the title Chore: Enable nestedFolders by default NestedFolders: Enable nested folders by default Mar 22, 2024
@joshhunt joshhunt mentioned this pull request Mar 22, 2024
Closed
@rgarcia89
Copy link

What kind of permission are required for users to be able to create subfolders? I would expect that Editor on the root folder Team A should be enough, since they are also able to create dashboards within that folder. However, they are not seeing the button to create new folders. While I as admin am seeing it.

@papagian
Copy link
Contributor

What kind of permission are required for users to be able to create subfolders? I would expect that Editor on the root folder Team A should be enough, since they are also able to create dashboards within that folder. However, they are not seeing the button to create new folders. While I as admin am seeing it.

based on this I think that the user need to have permission to create subfolders inside the folder
@joshhunt can you confirm?

@rgarcia89
Copy link

@papagian understood. But where is this permission coming from? It doesn't seem to be part of the Editor role. I have opened an issue for that #88120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolzhabayev tolzhabayev tolzhabayev approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@tskarhed tskarhed Awaiting requested review from tskarhed tskarhed is a code owner automatically assigned from grafana/grafana-frontend-platform

@JoaoSilvaGrafana JoaoSilvaGrafana Awaiting requested review from JoaoSilvaGrafana JoaoSilvaGrafana is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees
No one assigned
Labels
add to changelog area/backend area/frontend no-backport Skip backport of PR type/docs
Projects
None yet
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

Feat request: Nested folder
6 participants
@zserge @rgarcia89 @papagian @tolzhabayev @joshhunt @fabrizio-grafana