Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Enable feature toggle enablePluginsTracingByDefault by default #84645

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

xnyo
Copy link
Member

@xnyo xnyo commented Mar 18, 2024

What is this feature?

Enable feature toggle enablePluginsTracingByDefault while still keeping it in the feature allowing to roll-back if necessary.

Why do we need this feature?

Change default behaviour in Grafana 11.

Who is this feature for?

Grafana operators, plugin authors, Grafana labs.

Which issue(s) does this PR fix?:

Fixes #84559

Special notes for your reviewer:

Wait for https://github.com/grafana/deployment_tools/pull/128950 to be merged before merging this one.

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@xnyo xnyo added this to the 11.0.x milestone Mar 18, 2024
@xnyo xnyo self-assigned this Mar 18, 2024
@xnyo xnyo changed the title WIP: Enable feature flag enablePluginsTracingByDefault by default WIP: Enable plugins tracing by default Mar 18, 2024
@xnyo xnyo changed the title WIP: Enable plugins tracing by default Plugins: Enable feature toggle enablePluginsTracingByDefault by default Mar 19, 2024
@xnyo xnyo marked this pull request as ready for review March 19, 2024 11:15
@xnyo xnyo requested review from grafanabot and a team as code owners March 19, 2024 11:15
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@xnyo xnyo requested a review from a team as a code owner March 22, 2024 09:07
@xnyo xnyo enabled auto-merge (squash) March 22, 2024 09:07
@xnyo xnyo merged commit ef5d717 into main Mar 22, 2024
13 checks passed
@xnyo xnyo deleted the giuseppe/remove-enablePluginsTracingByDefault branch March 22, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Default feature toggle enablePluginsTracingByDefault to true
3 participants