Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram: Add support for stacking mode #84693

Merged
merged 9 commits into from
Mar 21, 2024
Merged

Conversation

adela-almasan
Copy link
Contributor

@adela-almasan adela-almasan commented Mar 18, 2024

Histogram stacking mode

histo_stacking.mov

Migration

histo_stacking_migrate.mov

Fixes #38047

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@adela-almasan adela-almasan changed the title [WIP]Histogram: Stacked mode Histogram: Stacking mode Mar 19, 2024
@adela-almasan adela-almasan marked this pull request as ready for review March 19, 2024 13:49
@adela-almasan adela-almasan requested review from grafanabot and a team as code owners March 19, 2024 13:49
@adela-almasan adela-almasan requested review from Develer, nmarrs, ashharrison90, eledobleefe and sunker and removed request for a team March 19, 2024 13:49
@adela-almasan adela-almasan changed the title Histogram: Stacking mode Histogram: Add support for stacking mode Mar 19, 2024
Copy link
Collaborator

@codeincarnate codeincarnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I can comment on all of this, but tested it out and worked fine.

Did make me curious how we're doing stacking order with histogram. It appears right now we're not re-ordering based on query order which I think is supposed to happen. But that can be done elsewhere 😄

@leeoniya
Copy link
Contributor

It appears right now we're not re-ordering based on query order which I think is supposed to happen.

there's no re-ordering. it stacks in order of the data, bottom up. the only way to change this is to reorder in the query or in a transform.

@adela-almasan adela-almasan merged commit 25a058f into main Mar 21, 2024
30 checks passed
@adela-almasan adela-almasan deleted the histogram_stacked branch March 21, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Histogram: stacked mode
4 participants