Alerting: Stop persisting silences and nflog to disk #84706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobsonMT
added
area/alerting
JacobsonMT
requested review from
rwwiv,
yuri-tceretian,
grobinson-grafana,
diegommm,
undef1nd and
suntala
and removed request for
a team
JacobsonMT
force-pushed
the
jacobsonmt/stop-disk-persisting-silence-nflog
branch
from
30bf8fa
to
32c9941
Compare
yuri-tceretian
approved these changes
Mar 20, 2024
JacobsonMT
force-pushed
the
jacobsonmt/stop-disk-persisting-silence-nflog
branch
from
bde59ff
to
5d25f08
Compare
ashharrison90
pushed a commit
that referenced
this pull request
Mar 26, 2024
With this change, we no longer need to persist silence/nflog states to disk in addition to the kvstore
ashharrison90
pushed a commit
that referenced
this pull request
Mar 26, 2024
With this change, we no longer need to persist silence/nflog states to disk in addition to the kvstore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Stops persisting silence state and nflog state to disk.
Why do we need this feature?
With the bump to
grafana/alerting, so no longer pass initial silence/nflog state to GrafanaAlertmanger via disk. With this change, we no longer need to persist the states to disk in addition to the kvstore.Who is this feature for?
Developers.
Special notes for your reviewer:
cleanupOrphanLocalOrgStateinMultiOrgAlertmanagerno longer needs to remove files from disk.