New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Enable feature toggle pluginsDynamicAngularDetectionPatterns
by default
#84723
Plugins: Enable feature toggle pluginsDynamicAngularDetectionPatterns
by default
#84723
Conversation
/deploy-to-hg |
|
|
pluginsDynamicAngularDetectionPatterns
by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally just use *setting.Cfg
instead of *config.PluginManagementCfg
in pkg/services/pluginsintegration/angulardetectorsprovider/dynamic.go
to keep things simpler. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🥇
You can probably remove the dependency on *config.PluginManagementCfg
eventually too since we get the GCOM URL from there for plugin management anyways!
What is this feature?
Enabled
pluginsDynamicAngularDetectionPatterns
by default and increases the interval for the checks from 1h to 24h to reduce impact once it reaches on-prem customers.As of today, the feature toggle is rolled out to 100% of prod instances in Grafana Cloud.
Follow up to #82880
You can use this dashboard to monitor the impact on GCOM
Related Slack thread.
Why do we need this feature?
Behavior change for Grafana 11.
Who is this feature for?
Grafana users with Angular plugins.
Which issue(s) does this PR fix?:
Fixes #84647
Special notes for your reviewer:
Should be merged after https://github.com/grafana/grafana-com/pull/9415
Please check that: