Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Enable feature toggle pluginsDynamicAngularDetectionPatterns by default #84723

Merged

Conversation

xnyo
Copy link
Member

@xnyo xnyo commented Mar 19, 2024

What is this feature?

Enabled pluginsDynamicAngularDetectionPatterns by default and increases the interval for the checks from 1h to 24h to reduce impact once it reaches on-prem customers.

As of today, the feature toggle is rolled out to 100% of prod instances in Grafana Cloud.

Follow up to #82880

You can use this dashboard to monitor the impact on GCOM

Related Slack thread.

Why do we need this feature?

Behavior change for Grafana 11.

Who is this feature for?

Grafana users with Angular plugins.

Which issue(s) does this PR fix?:

Fixes #84647

Special notes for your reviewer:

Should be merged after https://github.com/grafana/grafana-com/pull/9415

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@xnyo
Copy link
Member Author

xnyo commented Mar 20, 2024

/deploy-to-hg

@ephemeral-instances-bot
Copy link

  • Preparing your instance. A comment containing your instance's url will be added to this PR when the instance is ready.
  • Your instance will be ready in ~10 minutes.
  • Check the GitHub actions tab to follow the workflow progress
  • Slack channel: #proj-ephemeral-hg-instances
  • Building instance with giuseppe/pluginsDynamicAngularDetectionPatterns-default-true oss branch and main enterprise branch. How to choose a branch

@ephemeral-instances-bot
Copy link

@xnyo xnyo marked this pull request as ready for review March 20, 2024 11:38
@xnyo xnyo requested review from grafanabot and a team as code owners March 20, 2024 11:38
@xnyo xnyo requested review from wbrowne, marefr, oshirohugo and tolzhabayev and removed request for a team March 20, 2024 11:38
@xnyo xnyo changed the title Plugins: Enable feature toggle pluginsDynamicAngularDetectionPatterns by default Plugins: Enable feature toggle pluginsDynamicAngularDetectionPatterns by default Mar 20, 2024
@xnyo xnyo requested a review from a team as a code owner March 21, 2024 13:14
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally just use *setting.Cfg instead of *config.PluginManagementCfg in pkg/services/pluginsintegration/angulardetectorsprovider/dynamic.go to keep things simpler. WDYT?

pkg/plugins/config/config.go Outdated Show resolved Hide resolved
@xnyo xnyo requested a review from wbrowne March 21, 2024 13:52
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🥇

You can probably remove the dependency on *config.PluginManagementCfg eventually too since we get the GCOM URL from there for plugin management anyways!

@xnyo xnyo enabled auto-merge (squash) March 21, 2024 14:04
@xnyo xnyo merged commit eb31f71 into main Mar 21, 2024
14 checks passed
@xnyo xnyo deleted the giuseppe/pluginsDynamicAngularDetectionPatterns-default-true branch March 21, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Default feature toggle pluginsDynamicAngularDetectionPatterns to true
3 participants