Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Enable simplified routing FF by default #84856

Merged
merged 4 commits into from Mar 22, 2024

Conversation

JacobsonMT
Copy link
Member

What is this feature?

Moves simplified routing feature flag alertingSimplifiedRouting to GA and enables by default. Removes admonitions from docs about the FF.

Why do we need this feature?

Simplified routing should be GA and enabled by default in G11.

Who is this feature for?

Grafana Alerting users.

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@JacobsonMT JacobsonMT added area/alerting Grafana Alerting add to changelog no-backport Skip backport of PR labels Mar 20, 2024
@JacobsonMT JacobsonMT added this to the 11.0.x milestone Mar 20, 2024
@JacobsonMT JacobsonMT requested a review from a team as a code owner March 20, 2024 18:21
@JacobsonMT JacobsonMT requested review from grobinson-grafana and removed request for a team March 20, 2024 18:21
@JacobsonMT JacobsonMT force-pushed the jacobsonmt/enable-simplfied-routing-by-default branch from e93c581 to f6a7e75 Compare March 20, 2024 20:13
@@ -2067,6 +2078,23 @@ func TestIntegrationAlertmanagerStatus(t *testing.T) {
}
}
`
cfgWithoutAutogen := fmt.Sprintf(cfgTemplate, `{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps move it to another PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test will fail without this change, I could perhaps disable the simplfied routing FF here instead but fixing the test seems best.

@brendamuir
Copy link
Contributor

Hey Matt -- so do we only need to keep this section in the docs then? https://grafana.com/docs/grafana-cloud/alerting-and-irm/alerting/alerting-rules/create-grafana-managed-rule/#configure-labels-and-notifications and can i delete this section (that describes the process when simplified is NOT enabled): https://grafana.com/docs/grafana-cloud/alerting-and-irm/alerting/alerting-rules/create-grafana-managed-rule/#configure-notifications ? if so, lets also delete that section with this PR :)

@JacobsonMT
Copy link
Member Author

Hey Matt -- so do we only need to keep this section in the docs then? https://grafana.com/docs/grafana-cloud/alerting-and-irm/alerting/alerting-rules/create-grafana-managed-rule/#configure-labels-and-notifications and can i delete this section (that describes the process when simplified is NOT enabled): https://grafana.com/docs/grafana-cloud/alerting-and-irm/alerting/alerting-rules/create-grafana-managed-rule/#configure-notifications ? if so, lets also delete that section with this PR :)

Ah, nice catch! Didn't realize the section was duplicated. Yes, I'll make the change in this PR.

@JacobsonMT JacobsonMT force-pushed the jacobsonmt/enable-simplfied-routing-by-default branch from 1ab81ce to 29dcaee Compare March 21, 2024 17:55
@JacobsonMT JacobsonMT force-pushed the jacobsonmt/enable-simplfied-routing-by-default branch from 29dcaee to fd912e1 Compare March 22, 2024 17:06
@JacobsonMT JacobsonMT merged commit 980b9a6 into main Mar 22, 2024
14 checks passed
@JacobsonMT JacobsonMT deleted the jacobsonmt/enable-simplfied-routing-by-default branch March 22, 2024 17:45
@fabrizio-grafana fabrizio-grafana removed this from the 11.0.x milestone Apr 4, 2024
@fabrizio-grafana fabrizio-grafana added this to the 11.0.0-preview milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants