New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Enable simplified routing FF by default #84856
Alerting: Enable simplified routing FF by default #84856
Conversation
e93c581
to
f6a7e75
Compare
@@ -2067,6 +2078,23 @@ func TestIntegrationAlertmanagerStatus(t *testing.T) { | |||
} | |||
} | |||
` | |||
cfgWithoutAutogen := fmt.Sprintf(cfgTemplate, `{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps move it to another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test will fail without this change, I could perhaps disable the simplfied routing FF here instead but fixing the test seems best.
Hey Matt -- so do we only need to keep this section in the docs then? https://grafana.com/docs/grafana-cloud/alerting-and-irm/alerting/alerting-rules/create-grafana-managed-rule/#configure-labels-and-notifications and can i delete this section (that describes the process when simplified is NOT enabled): https://grafana.com/docs/grafana-cloud/alerting-and-irm/alerting/alerting-rules/create-grafana-managed-rule/#configure-notifications ? if so, lets also delete that section with this PR :) |
Ah, nice catch! Didn't realize the section was duplicated. Yes, I'll make the change in this PR. |
1ab81ce
to
29dcaee
Compare
29dcaee
to
fd912e1
Compare
What is this feature?
Moves simplified routing feature flag
alertingSimplifiedRouting
to GA and enables by default. Removes admonitions from docs about the FF.Why do we need this feature?
Simplified routing should be GA and enabled by default in G11.
Who is this feature for?
Grafana Alerting users.
Please check that: