Datasources: Fix expressions that reference hidden queries #84977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
requested review from
dprokop and
bfmatei
and removed request for
a team
andresmgot
approved these changes
Mar 22, 2024
sunker
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
The Change query filtering PR that was merged yesterday introduced a bug that caused expression queries that referenced hidden queries to stop working. This PR changes the order of things in the query runner, ensuring expression data source query method is triggered before any filtering takes place (in case target includes expression queries).
Why do we need this feature?
Who is this feature for?
Users of Grafana
Which issue(s) does this PR fix?:
Fixes #84976
Special notes for your reviewer:
Please check that: