Alerting: Editor role can access all provisioning API #85022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri-tceretian
changed the title
yuri-tceretian
force-pushed
the
yuri-tceretian/provisioner-permission
branch
from
83954c0
to
bc54d68
Compare
yuri-tceretian
added
area/alerting
yuri-tceretian
changed the title
yuri-tceretian
requested review from
a team,
rwwiv,
JacobsonMT and
grobinson-grafana
and removed request for
a team
yuri-tceretian
force-pushed
the
yuri-tceretian/provisioner-permission
branch
from
f179ba5
to
be84dc1
Compare
JacobsonMT
reviewed
Mar 22, 2024
JacobsonMT
approved these changes
Mar 22, 2024
ashharrison90
pushed a commit
that referenced
this pull request
Mar 26, 2024
ashharrison90
pushed a commit
that referenced
this pull request
Mar 26, 2024
can this be done for admin api provisions too so that editor can reload alerts this is needed for new alerting and provisioning |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
After PR #77007 is merged the Editor role can access the provisioning rule API. This PR adds the ability to access notification provisioning APIs.
Also, it introduces a new action
alert.provisioning.provenance:writewhich controls whether the user can access provisioning write APIs. This action is given to Editor role by default.In Grafana Enterprise, it can be removed in order to prevent Editors from using provisioning APIs.
Why do we need this feature?
Give access to Editor role to alerting provisioning API and provide ability to disable that in Grafana Enterprise.
Who is this feature for?
Related to #77007
Special notes for your reviewer:
Please check that: