Keybindings: Replace mod+h as help shortcut with ? #85449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskarhed
requested review from
Clarity-89 and
L-M-K-B
and removed request for
a team
joshhunt
approved these changes
Apr 2, 2024
xlson
added a commit
that referenced
this pull request
Apr 2, 2024
* origin/main: Update dependency i18next-browser-languagedetector to v7.2.1 Cloudmigration: swagger for the cloudmigration api (#85255) Update dependency glob to v10.3.12 Update dependency @types/react-dom to v18.2.23 InfluxDB: Fix measurement interpolation on visual query builder (#85423) Update dependency @types/eslint to v8.56.7 Add optional `queries` parameter to DataSourceGetTagValuesOptions (#85436) Update dependency @grafana/plugin-e2e to v0.25.1 (#85451) Keybindings: Replace mod+h as help shortcut with ? (#85449) Update Yarn to v4.1.1 (#85350) Update plugin SDK to v0.219.0 (#85438) Makefile: refactoring .PHONY (#85440) Explore: Add padding to query content in query inspector (#85309) DashboardScene: Fix issues with dashboard empty state (#85406) Canvas: Fix ellipse datalink example in gdev dashboard (#85398) Canvas: Add flowchart example to gdev (#85417) Plugins: Set correct PDC config values for proxy requests (#85412) Scopes: Add basic integration tests (#85351)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Removes anything with
h, as it tends to interfere with other shortcuts. Also displays that?can be used to view the help modal.Removes the changes in #82253 that initially fixed #74841
Why do we need this feature?
A lot of key combinations with
hare already taken by either the OS or the web browser. Using?for the help modal already works, and seems to be a standard practice across several large web apps.Who is this feature for?
Shortcut people.
Which issue(s) does this PR fix?:
Fixes #85321
Special notes for your reviewer:
Please check that: