Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11.0.x] Angular deprecation: Prefer local "angularDetected" value to the remote one #85632

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

xnyo
Copy link
Member

@xnyo xnyo commented Apr 5, 2024

Backport c033a15 from #85571


What is this feature?

Ensures that, in the catalog, Grafana prefers the local angularDetected value (provided by the Grafana backend, so the value for the plugin that's actually installed) to the remote one (provided by GCOM, so the value for the latest version published in the catalog).

This fixes an issue where the angular badge and warning are displayed in the catalog pages when testing an unpublished plugin that has stopped using Angular, but whose latest published version in GCOM is marked as angularDetected = true.

Before this PR, in such scenario Grafana used to prefer the value in GCOM (angularDetected = true) to the one for the new unpublished version (angularDetected = false).

This new behaviour introduced in the PR is more clear, especially for plugin developers who are testing a WIP/unpublished plugin update that migrated the plugin from Angular to React.

Why do we need this feature?

Solves confusion for plugin developers migrating Angular plugins to React.

Who is this feature for?

Plugin developers, but all Grafana users in general as well, because this behaviour makes more sense.

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

…te one (#85571)

* Angular deprecation: Prefer local value to remote

* Update tests

(cherry picked from commit c033a15)
@xnyo xnyo added this to the 11.0.x milestone Apr 5, 2024
@xnyo xnyo requested a review from a team as a code owner April 5, 2024 09:19
@xnyo xnyo requested review from sunker and removed request for a team April 5, 2024 09:19
@xnyo xnyo self-assigned this Apr 5, 2024
@xnyo xnyo merged commit 987d674 into v11.0.x Apr 5, 2024
24 checks passed
@xnyo xnyo deleted the backport-85571-to-v11.0.x branch April 5, 2024 09:47
@fabrizio-grafana fabrizio-grafana modified the milestones: 11.0.x, 11.0.0 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants