[v11.0.x] Angular deprecation: Prefer local "angularDetected" value to the remote one #85632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c033a15 from #85571
What is this feature?
Ensures that, in the catalog, Grafana prefers the local
angularDetected
value (provided by the Grafana backend, so the value for the plugin that's actually installed) to the remote one (provided by GCOM, so the value for the latest version published in the catalog).This fixes an issue where the angular badge and warning are displayed in the catalog pages when testing an unpublished plugin that has stopped using Angular, but whose latest published version in GCOM is marked as
angularDetected = true
.Before this PR, in such scenario Grafana used to prefer the value in GCOM (
angularDetected = true
) to the one for the new unpublished version (angularDetected = false
).This new behaviour introduced in the PR is more clear, especially for plugin developers who are testing a WIP/unpublished plugin update that migrated the plugin from Angular to React.
Why do we need this feature?
Solves confusion for plugin developers migrating Angular plugins to React.
Who is this feature for?
Plugin developers, but all Grafana users in general as well, because this behaviour makes more sense.
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: